BUG: Seed RNG in test_partially_invalid_plot_data #6670
Merged
+50
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gr8! nice to remove the randomness.. I think this might set some global state (which is prob ok), maybe do at the top of the file? |
|
I didn't see a context manager for the seed, so I defined one in Do we need a release note? This is mostly internal. |
|
no release note needed...go ahead when green |
|
yep you started with master so if this passes then ok |
TomAugspurger
pushed a commit
that referenced
this pull request
Mar 19, 2014
BUG/ENH: RNG ContextManager. Use in test_partially_invalid_plot_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came up upon merging another PR. See comment #6644 (comment)
The test relies on drawing at least 1 draw out of 10 uniform draw to be larger than 0.5; even if this didn't cause the failure originally, it should still be fixed. I set a seed that's known to produce the desired values.